Messages in this thread | | | Subject | Re: [RFC Patch net-next 4/5] sunrpc: use generic union inet_addr | From | Cong Wang <> | Date | Mon, 01 Jul 2013 15:11:57 +0800 |
| |
On Thu, 2013-06-27 at 16:36 +0100, Ben Hutchings wrote: > On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote: > [...] > > -/** > > - * rpc_cmp_addr - compare the address portion of two sockaddrs. > > - * @sap1: first sockaddr > > - * @sap2: second sockaddr > > - * > > - * Just compares the family and address portion. Ignores port, but > > - * compares the scope if it's a link-local address. > > You're removing the scope comparison.
Actually I added the following code in patch 5/5:
+ if (!ipv6_addr_equal(&a->sin6.sin6_addr, &b->sin6.sin6_addr)) + return false; + else if (__ipv6_addr_needs_scope_id(__ipv6_addr_type(&a->sin6.sin6_addr))) + return a->sin6.sin6_scope_id == b->sin6.sin6_scope_id;
but I should move it to this patch, otherwise it is hard for review.
Thanks!
| |