Messages in this thread | | | Date | Mon, 1 Jul 2013 11:17:20 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH] DMA: Fix Marvell Orion and mv_xor after MEMSET removal |
| |
On Mon, Jul 01, 2013 at 05:14:25PM +0200, Sebastian Hesselbarth wrote: > On 07/01/13 17:04, Jason Cooper wrote: > >On Mon, Jul 01, 2013 at 04:56:29PM +0200, Sebastian Hesselbarth wrote: > >>Commit 834cbfe966bece50afded79da8e975d255bf0772 > >> ("drivers/dma: remove unused support for MEMSET operations") > >>removes MEMSET from dmaengine but does not completely removes it from > >>Marvell Orion (arch/arm/plat-orion) and XOR (drivers/dma/mv_xor). > >>This also fixes some compiler warnings about now obsolete functions by > >>removing those. > >> > >>Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > >>--- > >>Cc: Jason Cooper <jason@lakedaemon.net> > >>Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > >>Cc: Kyungmin Park <kyungmin.park@samsung.com> > >>Cc: Andrew Morton <akpm@linux-foundation.org> > >>Cc: linux-arm-kernel@lists.infradead.org > >>Cc: linux-kernel@vger.kernel.org > >>--- > >> arch/arm/plat-orion/common.c | 6 ------ > >> drivers/dma/mv_xor.c | 25 +------------------------ > >> 2 files changed, 1 insertions(+), 30 deletions(-) > > > >Please take a look at the email from lkml I just forwarded to you. I > >believe this solves your problem, but I don't have time to look closely > >atm. > > Jason, > > I have seen the forwarded patch before. I don't know what version this > is based on. Some of the modifications are in next-20130701, some are > not. I have stripped the Marvell modifications from the patch you > forwarded and fixed all remaining issues. > > Also, I will sent a follow-up patch to remove memset references from > Marvell SoC dts/dtsi and the binding documentation soon. > > I guess, Bartolomiej should pick them up and resend his patch set, or > leave Marvell alone and you pick them up.
If Bartolomiej doesn't take it, please split your changes into two patches, one for plat-orion, and one for drivers.
thx,
Jason.
| |