lkml.org 
[lkml]   [2013]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] add a WARN in setup_irq function for the IRQF_DISABLED flag
On 06/08/2013 12:17 AM, Daniel Lezcano wrote:
>
> Hi,
>
> we are still seeing drivers with the irq flag IRQF_DISABLED present and
> *new* drivers submitted with this flag set.
>
> I am wondering if we can add a WARN in the setup_irq function about this
> flag. May be it is a bit rough but people will pay attention.

s/rough/brutal :)

> Thanks
>
> -- Daniel
>
> Index: clockevents/kernel/irq/manage.c
> ===================================================================
> --- clockevents.orig/kernel/irq/manage.c 2013-06-05
> 23:57:22.723446115 +0200
> +++ clockevents/kernel/irq/manage.c 2013-06-08 00:12:19.985035465 +0200
> @@ -1212,6 +1212,9 @@ int setup_irq(unsigned int irq, struct i
>
> if (WARN_ON(irq_settings_is_per_cpu_devid(desc)))
> return -EINVAL;
> +
> + WARN(act->flags & IRQF_DISABLED, "IRQF_DISABLED flag is disabled");
> +
> chip_bus_lock(desc);
> retval = __setup_irq(irq, desc, act);
> chip_bus_sync_unlock(desc);
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-06-08 00:41    [W:0.345 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site