lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant
    From
    On Mon, Jun 3, 2013 at 1:59 AM, Heiko Stübner <heiko@sntech.de> wrote:
    > Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc
    > controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to
    > always be set.
    >
    > There also seem to be no other modifications (additional register etc)
    > present, so to keep the footprint low, add this small variant to the
    > pltfm driver.

    Few comments below.

    > --- a/drivers/mmc/host/dw_mmc-pltfm.c
    > +++ b/drivers/mmc/host/dw_mmc-pltfm.c
    > @@ -24,6 +24,16 @@
    >
    > #include "dw_mmc.h"
    >
    > +

    No need to add extra empty line here.

    > +static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)

    > @@ -63,20 +73,6 @@ int dw_mci_pltfm_register(struct platform_device *pdev,
    > }
    > EXPORT_SYMBOL_GPL(dw_mci_pltfm_register);
    >
    > -static int dw_mci_pltfm_probe(struct platform_device *pdev)
    > -{
    > - return dw_mci_pltfm_register(pdev, NULL);
    > -}
    > -
    > -int dw_mci_pltfm_remove(struct platform_device *pdev)
    > -{
    > - struct dw_mci *host = platform_get_drvdata(pdev);
    > -
    > - dw_mci_remove(host);
    > - return 0;
    > -}
    > -EXPORT_SYMBOL_GPL(dw_mci_pltfm_remove);
    > -

    If you want to move those through code, please do separate patch.

    --
    With Best Regards,
    Andy Shevchenko
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-06-06 23:21    [W:4.880 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site