lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 106/184] USB: serial: Fix memory leak in sierra_release()
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

    commit f7bc5051667b74c3861f79eed98c60d5c3b883f7 upstream.

    I found a memory leak in sierra_release() (well sierra_probe() I guess)
    that looses 8 bytes each time the driver releases a device.

    Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
    Acked-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/usb/serial/sierra.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
    index 1b5c9f8..0cbf847 100644
    --- a/drivers/usb/serial/sierra.c
    +++ b/drivers/usb/serial/sierra.c
    @@ -925,6 +925,7 @@ static void sierra_release(struct usb_serial *serial)
    continue;
    kfree(portdata);
    }
    + kfree(serial->private);
    }

    #ifdef CONFIG_PM
    --
    1.7.12.2.21.g234cd45.dirty




    \
     
     \ /
      Last update: 2013-06-05 02:21    [W:3.327 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site