lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mfd: DT bindings for the palmas family MFD
Date


> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Tuesday, June 04, 2013 2:09 AM
> To: Lee Jones
> Cc: J, KEERTHY; linux-kernel@vger.kernel.org; linux-
> doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org;
> broonie@opensource.wolfsonmicro.com; rob.herring@calxeda.com;
> rob@landley.net; mturquette@linaro.org; sameo@linux.intel.com;
> wim@iguana.be; lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero;
> Ian Lartey
> Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD
>
> On 06/03/2013 08:18 AM, Lee Jones wrote:
> > On Mon, 03 Jun 2013, J Keerthy wrote:
> >> Add the various binding files for the palmas family of chips. There
> >> is a top level MFD binding then a seperate binding for regulators IP
> blocks on chips.
>
> >> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
> >> b/Documentation/devicetree/bindings/mfd/palmas.txt
>
> >> +Example:
> >> +
> >> +palmas {
> >
> > Should this be 'palmas@48 {', as it has an address?
>
> It's common to only include the unit-address (@48) if it's needed to
> make the node name unique (i.e. if you had multiple palmas devices).

Yeah. We generally have one Palmas device.

>
> >> diff --git
> >> a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> >> b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>
> > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> >
> >> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 -
> auto,
> >> + 2 - eco, 3 - forced pwm
> >
> > I've seen lots of sleep-mode properties, can't we define a generic
> > one?
>
> Isn't it HW-specific?

Yeah. Hence it is ti,sleep-mode.

Regards,
Keerthy
\
 
 \ /
  Last update: 2013-06-04 09:01    [W:0.103 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site