Messages in this thread | | | Date | Tue, 04 Jun 2013 15:52:16 -0700 | From | Rohit Vaswani <> | Subject | Re: [PATCH 2/3] ARM: msm: Re-organize platsmp to make it extensible |
| |
On 6/4/2013 2:32 AM, Russell King - ARM Linux wrote: > On Mon, Jun 03, 2013 at 05:19:44PM -0700, Rohit Vaswani wrote: >> + sc1_base_ptr = of_iomap(dn, 0); >> + if (sc1_base_ptr) { >> + writel_relaxed(0, sc1_base_ptr + VDD_SC1_ARRAY_CLAMP_GFS_CTL); >> + writel_relaxed(0, sc1_base_ptr + SCSS_CPU1CORE_RESET); >> + writel_relaxed(3, sc1_base_ptr + SCSS_DBG_STATUS_CORE_PWRDUP); >> + mb(); >> + iounmap(sc1_base_ptr); > If you need to fiddle with power rails and resets for your secondary > core, you don't need any of the pen_release stuff, and you really > should get rid of it. The pen_release stuff is only there for > platforms where there's no proper way of controlling the secondary > CPUs except by using a software method.
We currently don't have hotplug support as that also needs pen_release. We still need to do this. We could change that behavior, but we would need more time for that. Please could we let this go through and cleanup the pen_release once we have hotplug working.
Thanks, Rohit Vaswani
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
| |