Messages in this thread | | | Date | Tue, 4 Jun 2013 07:48:56 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 0/2] introduce list_for_each_entry_del |
| |
On Mon, Jun 03, 2013 at 03:55:55PM -0400, J??rn Engel wrote: > Actually, when I compare the two invocations, I prefer the > list_for_each_entry_del() variant over list_pop_entry(). > > while ((ref = list_pop_entry(&prefs, struct __prelim_ref, list))) { > list_for_each_entry_del(ref, &prefs, list) { > > Christoph?
I really don't like something that looks like an iterator (*for_each*) to modify a list. Maybe it's just me, so I'd love to hear others chime in.
| |