Messages in this thread | | | Date | Tue, 4 Jun 2013 14:17:36 +0300 | Subject | Re: [PATCH 2/2] ext4: add sanity checks in __ext4_check_dir_entry | From | Ruslan Bilovol <> |
| |
Hi Ted,
On Mon, Jun 3, 2013 at 6:40 PM, Theodore Ts'o <tytso@mit.edu> wrote: > On Mon, Jun 03, 2013 at 01:00:16PM +0300, Ruslan Bilovol wrote: >> Added checks for NULL before dereferencing some pointers >> >> + if (!de || !bh || !dir) >> + return 1; > > Do you know which one of these pointers was NULL?
In my particular case, the ''de" pointer is NULL
Regards, Ruslan
> > I want't make sure we're fixing the root issue as opposed to papering > over it. I'm not seeing how any of these pointers could have been > NULL (at least in my upstream kernel), and while I believe that this > helped for your kernel, I want to make sure we understand exactly what > was going on. > > Thanks, > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Best regards, Ruslan Bilvol
| |