Messages in this thread | | | Date | Tue, 4 Jun 2013 17:21:16 +0300 | Subject | Re: [PATCH, resend] pch_phub: re-use native MAC address parser | From | Andy Shevchenko <> |
| |
On Tue, Jun 4, 2013 at 5:03 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 28 May 2013, Andy Shevchenko wrote: >> We have mac_pton() helper to parse MAC addresses. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Acked-by: Arnd Bergmann <arnd@arndb.de> > > Hmm, the patch has appeared in linux-next now, and I'm now getting > randconfig build errors when CONFIG_NET is disabled, since > mac_pton is undefined then.
Thanks for catching this.
> The easiest solution would be to > make the entire driver "depend on NET".
I don't feel that is good idea. Driver is an abstraction to the ROM, it doesn't mean you can't read ROM without network framework. It seems proper solution is to move mac_pton() outside of CONFIG_NET, though I don't know how to do this easily.
-- With Best Regards, Andy Shevchenko
| |