lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH, resend] pch_phub: re-use native MAC address parser
From
On Tue, Jun 4, 2013 at 5:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 28 May 2013, Andy Shevchenko wrote:
>> We have mac_pton() helper to parse MAC addresses.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Hmm, the patch has appeared in linux-next now, and I'm now getting
> randconfig build errors when CONFIG_NET is disabled, since
> mac_pton is undefined then.

Thanks for catching this.

> The easiest solution would be to
> make the entire driver "depend on NET".

I don't feel that is good idea. Driver is an abstraction to the ROM,
it doesn't mean you can't read ROM without network framework.
It seems proper solution is to move mac_pton() outside of CONFIG_NET,
though I don't know how to do this easily.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2013-06-05 08:01    [W:0.044 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site