Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver() | Date | Mon, 03 Jun 2013 13:59:31 -0700 |
| |
Grygorii Strashko <grygorii.strashko@ti.com> writes:
> The OMAP I2C driver has a relation to pinctrl-single driver. As result, > its probe will be deferred during system boot until late init time, > because the pinctrl-single is initizalized as moudle/device init time. > This, in turn, will delay initialization of all I2C devices (like mfd, > I2C regulators and etc.) and cause boot delay (more over, it can broken > initialization of drivers which are not ready to use deferred probe > mechanism yet, for example DSS). > > There are no sense to keep OMAP I2C initialization on subsys init layer > any more, hence shift it to module/device layer where the i2c <--> > pinctrl-single dependency is resolved in drivers/Makefile now. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: "Ben Dooks (embedded platforms)" <ben-linux@fluff.org> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > Cc: linux-omap@vger.kernel.org > Cc: linux-i2c@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Testing this patch with PATCH 1/2, the twl_rtc driver fails to correctly initialize on OMAP3:
twl_rtc rtc.22: hctosys: invalid date/time
instead of the expected result:
twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)
so something is still not right for the init sequence.
Kevin
| |