Messages in this thread | | | Date | Thu, 27 Jun 2013 18:27:20 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2 v3] tracing/uprobes: Support ftrace_event_file base multibuffer |
| |
On 06/27, Srikar Dronamraju wrote: > > * zhangwei(Jovi) <jovi.zhangwei@huawei.com> [2013-06-25 11:30:20]: > > + if (!enabled) { > > + tu->consumer.filter = filter; > > + ret = uprobe_register(tu->inode, tu->offset, &tu->consumer); > > + if (ret) > > + tu->flags &= file ? ~TP_FLAG_TRACE : ~TP_FLAG_PROFILE; > > Dont we need to free link here? or where does the link that got > allocated freed?
Agreed...
Masami, it seems that (just in case, with or without "Turn trace_probe->files into list_head" I sent) trace_kpobes needs the similar fix too? Plus it should clear TP_FLAG_* if enable_k.*probe() fails.
Or enable_trace_probe() assumes that enable_kprobe() must succeed? In this case probably WARN_ON(ret) makes sense.
Oleg.
| |