lkml.org 
[lkml]   [2013]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] misc/bmp085: Enable building as a module
On 13:16 Tue 25 Jun     , Ben Hutchings wrote:
> On Tue, 2013-06-25 at 09:27 +0200, Eric Andersson wrote:
> > On 15:10 Mon 24 Jun , Ben Hutchings wrote:
> > > Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> > > driver' changed the BMP085 config symbol to a boolean. I see no
> > > reason why the shared code cannot be built as a module, so change it
> > > back to tristate.
> > >
> > > Cc: Eric Andersson <eric.andersson@unixphere.com>
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > ---
> > > drivers/misc/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index c002d86..7a68184 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -451,7 +451,7 @@ config ARM_CHARLCD
> > > still useful.
> > >
> > > config BMP085
> > > - bool
> > > + tristate
> > > depends on SYSFS
> > >
> > > config BMP085_I2C
> > >
> >
> > There is no reason for building the common code stand-alone. The BMP085
> > config option is only selectable via the BMP085_I2C/_SPI options.
>
> Yes, but it is then always built-in.

Good point. This change is fine by me.

--
Best regards,
Eric

http://www.unixphere.com


\
 
 \ /
  Last update: 2013-06-26 14:01    [W:0.048 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site