Messages in this thread | | | Subject | Re: [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys | From | Andy Shevchenko <> | Date | Wed, 26 Jun 2013 11:46:26 +0300 |
| |
On Tue, 2013-06-25 at 18:53 -0700, Darren Hart wrote: > Configure the four buttons tied to the E6XX GPIO lines on the > MinnowBoard as keys using the gpio-keys-polled platform driver. From > left to right, bind them to LEFT, DOWN, UP, RIGHT, similar to the VI > directional keys. > > This is separate from the minnowboard driver to provide users with the > flexibility to write kernel drivers for their own devices using these GPIO > lines.
I'm repeating my comment I did early to you.
I think this driver is a wrong approach, since you just use gpio_keys_polling with custom platform data. So, it should go to the platform code / board file under arch/x86/platform/minnow/...
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |