Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 13/13] cpufreq: make sure frequency transitions are serialized | Date | Mon, 24 Jun 2013 15:33:41 +0200 |
| |
On Monday, June 24, 2013 06:46:39 PM Viresh Kumar wrote: > On 24 June 2013 18:53, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > You can do > > > > if (WARN(transition_ongoing, "<text>")) > > return; > > > > and below analogously. > > Ahh.. stupid code.. Check if this fixup is fine (attached too)
Looks OK, but since transition_ongoing is either 0 or 1 now, as far as I can say, it would be better to make it a bool and use = true/false instead of ++/-- I suppose.
Thanks, Rafael
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 6624694..6ca7eac 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -267,10 +267,9 @@ void __cpufreq_notify_transition(struct > cpufreq_policy *policy, > switch (state) { > > case CPUFREQ_PRECHANGE: > - if (transition_ongoing) { > - WARN(1, "In middle of another frequency transition\n"); > + if (WARN(transition_ongoing, > + "In middle of another frequency transition\n")) > return; > - } > > transition_ongoing++; > > @@ -293,10 +292,9 @@ void __cpufreq_notify_transition(struct > cpufreq_policy *policy, > break; > > case CPUFREQ_POSTCHANGE: > - if (!transition_ongoing) { > - WARN(1, "No frequency transition in progress\n"); > + if (WARN(!transition_ongoing, > + "No frequency transition in progress\n")) > return; > - } > > transition_ongoing--; -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |