Messages in this thread | | | Date | Fri, 21 Jun 2013 16:19:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: max77693: Add max77693 regualtor driver. |
| |
On Thu, Jun 20, 2013 at 04:03:26PM +0900, Jonghwa Lee wrote: > This patch adds new regulator driver to support max77693 chip's regulators. > max77693 has two linear voltage regulators and one current regulator which > can be controlled through I2C bus. This driver also supports device tree.
This is fine but doesn't have a binding document which is needed for new DT bindings.
A comment in the is_enabled() function explaining that more than one bit might be set (or replacing it with the generic function) would also be good. [unhandled content-type:application/pgp-signature] | |