Messages in this thread | | | Subject | Re: [PATCH v7] ethernet/arc/arc_emac - Add new driver | From | Joe Perches <> | Date | Fri, 21 Jun 2013 07:43:33 -0700 |
| |
On Fri, 2013-06-21 at 10:53 +0000, Alexey Brodkin wrote: > On 06/21/2013 02:32 PM, Joe Perches wrote: > > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote: > >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > >> instantiated in some legacy ARC (Synopsys) FPGA Boards such as > >> ARCAngel4/ML50x. [] > >> + rxbd->data = (unsigned char *)cpu_to_le32(rx_buff->skb->data); > > > > 32 bit only. Should the Kconfig block have some arch_arc dependency > > so it can't get compiled for 64 bit systems? [] > So for now I may easily add dependency on ARC if it makes acceptance of > driver easier.
I don't think it's a big problem.
Maybe add a Kconfig "depends on !64BIT".
Another thing to do would be to run it through sparse with make C=1
| |