lkml.org 
[lkml]   [2013]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH char-misc-next] UIO: Fix concurrency issue
On Thu 2013-06-20 16:36:00, Vitalii Demianets wrote:
> In a SMP case there was a race condition issue between
> uio_pdrv_genirq_irqcontrol() running on one CPU and irq handler on another
> CPU. Fix it by spin_locking shared resources access inside irq handler.
> Also:
> - Change disable_irq to disable_irq_nosync to avoid deadlock, because
> disable_irq waits for the completion of the irq handler;
> - Change atomic bit-manipulation routines to their non-atomic counterparts
> as we already are guarding the code by spinlock.
>
> Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>

Sounds good.

Reviewed-by: Pavel Machek <pavel@ucw.cz>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2013-06-21 15:21    [W:0.033 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site