Messages in this thread | | | Date | Fri, 21 Jun 2013 14:44:32 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH char-misc-next] UIO: Fix concurrency issue |
| |
On Thu 2013-06-20 16:36:00, Vitalii Demianets wrote: > In a SMP case there was a race condition issue between > uio_pdrv_genirq_irqcontrol() running on one CPU and irq handler on another > CPU. Fix it by spin_locking shared resources access inside irq handler. > Also: > - Change disable_irq to disable_irq_nosync to avoid deadlock, because > disable_irq waits for the completion of the irq handler; > - Change atomic bit-manipulation routines to their non-atomic counterparts > as we already are guarding the code by spinlock. > > Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Sounds good.
Reviewed-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |