Messages in this thread | | | Date | Fri, 21 Jun 2013 11:06:17 +0200 | From | Michal Simek <> | Subject | Re: [RFC PATCH 2/2] uio: Add two platform uio drivers to one |
| |
On 06/21/2013 01:13 AM, Pavel Machek wrote: > Hi! > >>>>> can you please comment this? >>>> >>>> I'll let Hans handle this, as he's the UIO maintainer now. >>> >>> Looks good to me. >>> >>> Anyway, Hans disappeared, so Greg takes patches, again. Take a look, >>> it seems I already did some changes you wanted, they are in char-misc >>> tree. >> >> Can you send me link to that repo? > > I googled a mirror... > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/char-misc/+/char-misc-next/drivers/uio/uio_pdrv_genirq.c
Ok. I see. Yeah it can be done in that way too.
I can rebase my patches on the top of that because they are still valid. 1/2 is not there and it is nice way how to simplify the code.
The purpose of 2/2 was to remove that uio_pdrv.c which is not needed when uio_pdrv_genirq.c also support no IRQ case.
Will be good if you can look at my patches and test them.
Also we should also simplify the driver by using devres groups, devm_kzalloc, etc.
Thanks, Michal
-- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[unhandled content-type:application/pgp-signature] | |