Messages in this thread | | | Date | Wed, 19 Jun 2013 08:52:06 -0600 | From | David Ahern <> | Subject | Re: [PATCH 3/3] perf tools: include termios.h explicitly |
| |
On 6/18/13 7:02 PM, Joonsoo Kim wrote: > Building perf for android is failed, because it can't find definition of > struct winsize. This definition is in termios.h, so I add this header > to util.h to solve the problem. It is missed by commit '2c803e52' which > moves get_term_dimensions() from builtin-top.c to util.c, but, missed to > move termios.h header.
Thank you for fixing this.
David
> > Cc: David Ahern <dsahern@gmail.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h > index a45710b..f2c6483 100644 > --- a/tools/perf/util/util.h > +++ b/tools/perf/util/util.h > @@ -72,6 +72,7 @@ > #include "types.h" > #include <sys/ttydefaults.h> > #include <lk/debugfs.h> > +#include <termios.h> > > extern const char *graph_line; > extern const char *graph_dotted_line; > @@ -274,6 +275,5 @@ void dump_stack(void); > > extern unsigned int page_size; > > -struct winsize; > void get_term_dimensions(struct winsize *ws); > #endif /* GIT_COMPAT_UTIL_H */ >
| |