Messages in this thread | | | Date | Mon, 17 Jun 2013 16:36:07 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/19] bh1770glc: added input device interface |
| |
On Tue, Jun 18, 2013 at 01:27:39AM +0200, Andi Shyti wrote: > Hi Greg, > > > > The driver generates an event in /dev/input/ under the name > > > 'bh1770'. It's a switch event where is reported '0' or '1' > > > whenever the sensor detects something crossing the threshold. > > > > > > Signed-off-by: Onur Atilla <oatilla@gmail.com> > > > Signed-off-by: Phil Carmody <pc@asdf.org> > > > Signed-off-by: Andi Shyti <andi@etezian.org> > > > --- > > > drivers/misc/bh1770glc.c | 58 +++++++++++++++++++++++++++++++++++++++++++++- > > > 1 file changed, 57 insertions(+), 1 deletion(-) > > > > Doesn't this mean that this driver is now an "input" driver, so it > > shouldn't be using the odd sysfs api, and should move to the > > drivers/input/ directory tree? > > The driver has also lots of interfaces in > sysfs that are used from userspace, like proximity value and > ambient light value. > > What the input interface provides is just one of the features > from the driver. Shall I move it anyway?
Hm, why not make it an iio driver instead? That way you get input and sysfs all together.
thanks,
greg k-h
| |