Messages in this thread | | | Date | Sat, 15 Jun 2013 14:59:28 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/3] hw_breakpoint: Simplify list/idx mess in toggle_bp_slot() paths |
| |
On Sat, Jun 01, 2013 at 09:45:48PM +0200, Oleg Nesterov wrote: > The enable/disable logic in toggle_bp_slot() is not symmetrical > and imho very confusing. "old_count" in toggle_bp_task_slot() is > actually new_count because this bp was already removed from the > list. > > Change toggle_bp_slot() to always call list_add/list_del after > toggle_bp_task_slot(). This way old_idx is task_bp_pinned() and > this entry should be decremented, new_idx is +/-weight and we > need to increment this element. The code/logic looks obvious. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Nice :-)
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
| |