Messages in this thread | | | Date | Wed, 12 Jun 2013 18:33:29 +0300 | From | Andrii Tseglytskyi <> | Subject | Re: [PATCH v2 2/2] PM / AVS: SmartReflex/class3: Fix order of initialization of SR class and SR driver |
| |
On 06/12/2013 04:32 PM, Tony Lindgren wrote: > * Kevin Hilman <khilman@linaro.org> [130610 10:58]: >> Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> writes: >> >>> SmartReflex consists of three entities: SR device, SR class and >>> SR driver. SmartReflex driver depends on SmartReflex class, but >>> order of their initialization is not clear. They both use >>> late_initcall(), and order depends on Makefile calls. >>> Patch moves initialization of SR class to device_initcall(), >>> and removes redundant call of sr_late_init(). >>> >>> This provides predictable order of SmartReflex initcalls: >>> 1. device_initcall() -> SmartReflex class init >>> 2. late_initcall() -> SmartReflex driver init >>> >>> Signed-off-by: Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> >> Tony will have to decide on whether he's OK with the initcall changes. >> >> I can queue this with the rest of the AVS changes with Tony's ack. > I'd rather not make anything earlier, relying on the Makefile is just > fine here. These pieces are always compiled in too. The reason why > we should only minimal things initialized earlier than module_init > is that this way we have a proper console initialized and see real > error messages without having to have DEBUG_LL + earlyprintk enabled. > > If anything else is needed, you have have just one late_initcall > that checks the return values of the various SR related init functions > to make sure all the dependencies are met. > > Regards, > > Tony > > Hi Tony,
Thank you for your comment - it sounds reasonable. Patch can be dropped from this patch series.
Regards, Andrii
| |