Messages in this thread | | | Date | Tue, 11 Jun 2013 15:10:37 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure |
| |
Hello.
On 11-06-2013 14:36, Sekhar Nori wrote:
>> From: KV Sujith <sujithkv@ti.com>
>> Add struct davinci_gpio_platform_data davinci gpio module.
>> Signed-off-by: KV Sujith <sujithkv@ti.com> >> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> As Linus commented before, this should be merged with 03/11.
>> --- >> include/linux/platform_data/gpio-davinci.h | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 include/linux/platform_data/gpio-davinci.h
>> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h >> new file mode 100644 >> index 0000000..f1c8277 >> --- /dev/null >> +++ b/include/linux/platform_data/gpio-davinci.h >> @@ -0,0 +1,27 @@ >> +/* >> + * gpio-davinci.h > > I would drop this unnecessary filename mention as well. > >> + * >> + * DaVinci GPIO Platform Related Defines >> + * >> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation version 2. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#ifndef __ASM_ARCH_DAVINCI_GPIO_H >> +#define __ASM_ARCH_DAVINCI_GPIO_H
> This should now be __PLATFORM_DATA_DAVINCI_GPIO_H__ or some such since > the file as been moved out of arch specific folder.
I think __GPIO_DAVINCI_H would be enough...
> Thanks, > Sekhar
WBR, Sergei
| |