Messages in this thread | | | Date | Thu, 9 May 2013 21:34:29 +0100 | From | Al Viro <> | Subject | Re: [git pull] more vfs.git stuff |
| |
On Thu, May 09, 2013 at 09:28:15PM +0100, Al Viro wrote:
> The only place checking that sucker is in a fairly large area protected by > ->b_lock (in mon_bin_event()); I really don't want to dig deep enough to > tell if having it changed right after it had been checked is safe. OTOH, > from a cursory look through that code it appears that the whole map_count > thing is completely misguided - it seems to assume that ->open() is called for > each VMA, including the one created by mmap(2). Sigh...
Less cursory one shows that they do call their ->open() from their ->mmap(). OTOH, the code looking and ->mmap_active looks fishy - what happens if we do allocation before mmap() happens?
Anyway, let's just drop that commit for now; it clearly needs more RTFS. Could you pull for-linus^?
| |