Messages in this thread | | | Date | Thu, 09 May 2013 20:58:55 +0400 | From | Sergei Shtylyov <> | Subject | Re: net: phy: realtek: add rtl8201f driver |
| |
Hello.
On 09-05-2013 6:35, Jongsung Kim wrote:
>> Removal of unused #define's is a matter of a separate cleanup patch...
> Sorry. I won't touch them.
>>> +static int rtl8201f_ack_interrupt(struct phy_device *phydev) { >>> + int err; >>> + >>> + err = phy_read(phydev, RTL8201F_ISR);
>> This could be an initializer and so make the function shorter.
> Agreed. I just thought it's better to make it similar to the > rtl821x_ack_interrupt.
Ah, then you may leave this code as is.
> Then, may I make shorter the rtl821x_ack_interrupt as > well as rtl8201f_ack_interrupt?
In a separate patch, if you wish.
WBR, Sergei
| |