lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] firmware: Avoid superfluous usermodehelper lock
From
On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai <tiwai@suse.de> wrote:
> When a firmware file can be loaded directly, there is no good reason
> to lock usermodehelper. It's needed only when the direct fw load
> fails and falls back to the user-mode helper.

I remembered that we discussed the problem before, :-)

Some crazy drivers might call request_firmware inside resume callback
(for example, USB devices might be rebind in resume), with
usermodehelper_read_lock, we can find the mistake easily and log it.

I am wondering if it is good to remove the usermodehelper lock.

Could you let us know any benefit to do it?

Thanks,
--
Ming Lei


\
 
 \ /
  Last update: 2013-05-08 18:21    [W:0.298 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site