Messages in this thread | | | Date | Fri, 31 May 2013 11:11:01 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 05/16] perf, persistent: Return resonable error code |
| |
On Fri, May 31, 2013 at 10:47:25AM +0200, Robert Richter wrote: > From: Robert Richter <robert.richter@calxeda.com> > > Returning -ENODEV if no file descriptor is found. An error code of -1 > (-EPERM) is misleading in this case. > > Signed-off-by: Robert Richter <robert.richter@calxeda.com> > --- > kernel/events/persistent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/persistent.c b/kernel/events/persistent.c > index 6612eb77..190aa75 100644 > --- a/kernel/events/persistent.c > +++ b/kernel/events/persistent.c > @@ -165,7 +165,7 @@ int perf_get_persistent_event_fd(unsigned cpu, struct perf_event_attr *attr) > if (desc->attr->config == attr->config) > return __alloc_persistent_event_fd(desc); > > - return -1; > + return -ENODEV;
Ditto.
| |