lkml.org 
[lkml]   [2013]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > Add a new column for showing callchain overhead. I feel like it's
> > more natural than having those overhead next to a first child in a
> > same column.
>
> Callchains in GTK, great! Some observations tho:
>
> All those leaves with 0.00% looks ugly/not needed, right?
>
> I took a screenshot and put at:
>
> http://vger.kernel.org/~acme/perf-gtk-callchains.png

Looks really nice!

I'm wondering, would it be hard to add alternating lightgrey+white
background colors to make the entries striped and for the horizontal
structure to thus stand out better?

The 'qgit' tool does that for example, to alternate git commit log
entries.

(Extra points for striping only where the line actually begins.)

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-05-28 11:21    [W:0.096 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site