lkml.org 
[lkml]   [2013]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/3] extcon: Palmas Extcon Driver
Hi Graeme/Kishon,

On Friday 24 May 2013 08:01 PM, Kishon Vijay Abraham I wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> This is the driver for the USB comparator built into the palmas chip. It
> handles the various USB OTG events that can be generated by cable
> insertion/removal.


I have following feedback on this driver to use this on Tegra platform:
1. Can we have very simple driver for detecting VBUS and ID and just
generate notification. No VBUS control logic or lots of USB related
configurations?
2. We will need the VBUS control as optional if it is require for TI
platform. Currently it is mandatory and hence it is not suite in our
context.
3. There is VBUS control (enabled/disable) in VBUS detection also. When
palma detect the VBUS then why actually it need to enable VBUS as VBUS
is already supplied by HOST? It may be only need when palma detect the
ID pin and maybe want to enable VBUS but again VBUS control
(enable/disable) should be part of USB driver, out of extcon driver.





\
 
 \ /
  Last update: 2013-05-25 19:41    [W:0.170 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site