lkml.org 
[lkml]   [2013]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages
(5/25/13 9:23 PM), Wanpeng Li wrote:
> Hi KOSAKI,
> On Sat, May 25, 2013 at 09:16:24PM -0400, KOSAKI Motohiro wrote:
>>> ---
>>> mm/page_alloc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 98cbdf6..23b921f 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
>>> list_del(&page->lru);
>>> rmv_page_order(page);
>>> zone->free_area[order].nr_free--;
>>> + if (PageHighMem(page))
>>> + totalhigh_pages -= 1 << order;
>>> for (i = 0; i < (1 << order); i++)
>>> SetPageReserved((page+i));
>>> pfn += (1 << order);
>>
>> memory hotplug don't support 32bit since it was born, at least, when the system has highmem.
>> Why can't we disable memory hotremove when 32bit at compile time?
>
> Here is logic memory remove instead of ACPI based memory remove. ;-)

I know.



\
 
 \ /
  Last update: 2013-05-26 04:01    [W:0.229 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site