Messages in this thread | | | Date | Thu, 23 May 2013 19:11:07 +0400 | From | Sergei Shtylyov <> | Subject | Re: [net-next RFC 3/8] macvtap: introduce macvtap_get_vlan() |
| |
Hello.
On 23-05-2013 7:12, Jason Wang wrote:
> Factor out the device holding logic to a macvtap_get_vlan(), this will be also > used by multiqueue API.
> Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > drivers/net/macvtap.c | 26 +++++++++++++++++++------- > 1 files changed, 19 insertions(+), 7 deletions(-)
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c > index ce1c72a..a36e49e 100644 > --- a/drivers/net/macvtap.c > +++ b/drivers/net/macvtap.c > @@ -890,6 +890,23 @@ out: > return ret; > } > > +static struct macvlan_dev *macvtap_get_vlan(struct macvtap_queue *q) > +{ > + struct macvlan_dev *vlan;
Empty line wouldn't hurt here, after declaration.
> + rcu_read_lock_bh(); > + vlan = rcu_dereference_bh(q->vlan); > + if (vlan) > + dev_hold(vlan->dev); > + rcu_read_unlock_bh(); > + > + return vlan; > +} [...]
WBR, Sergei
| |