lkml.org 
[lkml]   [2013]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] nouveau: replace large udelay by mdelay
On 05/22/2013 12:48 PM, Marc Dietrich wrote:
> ARM has a maximum of 2000 usec delay. Use mdelay for larger delays.
> This affects distro kernels mostly.
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
> drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> index d0817d9..ed7415e 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> @@ -51,7 +51,8 @@ nv50_dac_sense(struct nv50_disp_priv *priv, int or, u32 loadval)
> const u32 doff = (or * 0x800);
> int load = -EINVAL;
> nv_wr32(priv, 0x61a00c + doff, 0x00100000 | loadval);
> - udelay(9500);
> + mdelay(9);
> + udelay(500);

That looks very ugly. Can you just use 9 or 10 instead of adding on the
extra 500uS?

David Daney



\
 
 \ /
  Last update: 2013-05-22 22:41    [W:0.061 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site