| Date | Tue, 21 May 2013 12:32:46 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 10/39] thp: account anon transparent huge pages into NR_ANON_PAGES |
| |
On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > We use NR_ANON_PAGES as base for reporting AnonPages to user. > There's not much sense in not accounting transparent huge pages there, but > add them on printing to user. > > Let's account transparent huge pages in NR_ANON_PAGES in the first place.
This is another one that needs to be pretty carefully considered _independently_ of the rest of this set. It also has potential user-visible changes, so it would be nice to have a blurb in the patch description if you've thought about this, any why you think it's OK.
But, it still makes solid sense to me, and simplifies the code.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
|