lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/4] ipmi: Improve error messages on failed irq enable
On Thu, May 16, 2013 at 12:04 PM, Corey Minyard <cminyard@mvista.com> wrote:
> When the interrupt enable message returns an error, the messages are
> not entirely accurate nor helpful. So improve them.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 313538a..af4b23f 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -663,8 +663,10 @@ static void handle_transaction_done(struct smi_info *smi_info)
> /* We got the flags from the SMI, now handle them. */
> smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
> if (msg[2] != 0) {
> - dev_warn(smi_info->dev, "Could not enable interrupts"
> - ", failed get, using polled mode.\n");
> + dev_warn(smi_info->dev,
> + "Couldn't get irq info: %x.\n", msg[2]);
> + dev_warn(smi_info->dev,
> + "Maybe ok, but ipmi might run very slowly.\n");
> smi_info->si_state = SI_NORMAL;
> } else {
> msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
> @@ -685,10 +687,12 @@ static void handle_transaction_done(struct smi_info *smi_info)
>
> /* We got the flags from the SMI, now handle them. */
> smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
> - if (msg[2] != 0)
> - dev_warn(smi_info->dev, "Could not enable interrupts"
> - ", failed set, using polled mode.\n");
> - else
> + if (msg[2] != 0) {
> + dev_warn(smi_info->dev,
> + "Couldn't set irq info: %x.\n", msg[2]);
> + dev_warn(smi_info->dev,
> + "Maybe ok, but ipmi might run very slowly.\n");
> + } else

Minor nit: it would be nice if these warnings were collapsed into a
single printk -- that would save me a whitelist entry of acceptable
KERN_WARNING messages :)

My Dell 12g server says:

[97627.407724] ipmi_si ipmi_si.0: Using irq 10
[97627.421369] ipmi_si ipmi_si.0: Couldn't set irq info: cc.
[97627.427389] ipmi_si ipmi_si.0: Maybe ok, but ipmi might run very slowly.

Tested-by: Andy Lutomirski <luto@amacapital.net>

--Andy


\
 
 \ /
  Last update: 2013-05-17 01:01    [W:0.062 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site