Messages in this thread | | | Date | Thu, 16 May 2013 19:13:37 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL |
| |
On 05/16, Lucas De Marchi wrote: > > > > > - kill or justify ->path[0] check > > I'm not sure about this, it's already there before my refactor and I > don't think it makes any good. From modprobe pespective, I'd say it > would be better to give an error than say everything went ok.
Agreed. And, I forgot to mention, if we kill this check then we do not need this patch (although I need to recheck), execve will fail and nothing bad should happen.
Just I think it would be better to start with the trivial fix, then decide what should we actually do.
> Acked-By: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks,
Oleg.
| |