lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote:
> "Nicholas A. Bellinger" <nab@linux-iscsi.org> writes:
> > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
> >> Asias He <asias@redhat.com> writes:
> >> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >> >
> >> > This patch fixes this build failure.
> >> >
> >> > From Randy Dunlap:
> >> > '''
> >> > on x86_64:
> >> >
> >> > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
> >> >
> >> > It needs to depend on NET since net/core/ provides that function.
> >> > '''
> >>
> >> Proper fix please.
> >>
> >> Though I can't see why you thought this was a good idea. Nonetheless, I
> >> shan't highlight why: I have far too much respect for your intellects
> >> and abilities.
> >>
> >> No, don't thank me!
> >
> > Hi Rusty & Asias,
> >
> > I assume you mean something like the following patch to allow kbuild to
> > work when VHOST_NET + VHOST_SCSI are both enabled and sharing vhost.o,
> > yes..?
>
> No, that's a separate issue.
>
> memcpy_fromiovec() has nothing to do with networking: that was just the
> first user. Note that crypto/algif_skcipher.c also uses it. The
> obvious answer is to move it into lib/.

That's true. I also want this.

> OTOH making vhost_scsi depend on CONFIG_NET is breathtakingly lazy. I
> expect better from experienced kernel hackers :(

But do you think moving the memcpy_fromiovec stuff is a 3.10 material?

> Rusty.

--
Asias


\
 
 \ /
  Last update: 2013-05-16 04:41    [W:0.064 / U:3.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site