Messages in this thread | | | Date | Sat, 27 Apr 2013 18:58:56 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len |
| |
On 04/26, Jacob Shin wrote: > > @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head **list, int *idx, > if (parse_breakpoint_type(type, &attr)) > return -EINVAL; > > - /* > - * We should find a nice way to override the access length > - * Provide some defaults for now > - */ > if (attr.bp_type == HW_BREAKPOINT_X) > attr.bp_len = sizeof(long); > + else if (len) > + attr.bp_len = len; > else > attr.bp_len = HW_BREAKPOINT_LEN_4;
Stupid question... So X86_FEATURE_BPEXT only works for r/w? I mean, it doesn't allow to specify the mask for an execute breakpoint?
Otherwise the code above should be probably updated, say,
if (!len) { len = attr.bp_type == HW_BREAKPOINT_X ? sizeof(long) : HW_BREAKPOINT_LEN_4; } attr.bp_len = len;
Oleg.
| |