lkml.org 
[lkml]   [2013]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 04/26] hugetlbfs: add swap entry check in follow_hugetlb_page()
On Thu, Apr 25, 2013 at 12:04:10AM +0100, Ben Hutchings wrote:
> On Tue, Apr 23, 2013 at 02:53:44PM -0700, Greg Kroah-Hartman wrote:
> > 3.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> >
> > commit 9cc3a5bd40067b9a0fbd49199d0780463fc2140f upstream.
> >
> > With applying the previous patch "hugetlbfs: stop setting VM_DONTDUMP in
> > initializing vma(VM_HUGETLB)" to reenable hugepage coredump, if a memory
> > error happens on a hugepage and the affected processes try to access the
> > error hugepage, we hit VM_BUG_ON(atomic_read(&page->_count) <= 0) in
> > get_page().
>
> Is this required? You didn't apply the previous patch referred to
> above (commit a2fce9143057) to 3.4.y or 3.0.y since it claimed to fix
> a regression in 3.7 (commit 314e51b9851b 'mm: kill vma flag VM_RESERVED
> and mm->reserved_vm counter').
>
> I'm not saying it *isn't* required, mind.

Yeah, but I went off of the stable: marking in this patch, which said:
Cc: <stable@vger.kernel.org> [2.6.34+?]


Naoya, any chance you could clear this up? Is this needed for kernels
older than 3.7?

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-04-25 01:41    [W:0.051 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site