lkml.org 
[lkml]   [2013]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND][PATCH RFT 2/2] pwm: lpc32xx: Don't change PWM_ENABLE bit in lpc32xx_pwm_config
On 04/23/2013 08:02 AM, Axel Lin wrote:
> lpc32xx_pwm_config() is supposed to set duty_ns and period_ns,
> it should not change PWM_ENABLE bit.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Tested-by: Roland Stigge <stigge@antcom.de>

> ---
> drivers/pwm/pwm-lpc32xx.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c
> index 1a5075e..e936202 100644
> --- a/drivers/pwm/pwm-lpc32xx.c
> +++ b/drivers/pwm/pwm-lpc32xx.c
> @@ -37,6 +37,7 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
> struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
> unsigned long long c;
> int period_cycles, duty_cycles;
> + u32 val;
>
> c = clk_get_rate(lpc32xx->clk) / 256;
> c = c * period_ns;
> @@ -68,8 +69,10 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
> c = 255;
> duty_cycles = 256 - c;
>
> - writel(PWM_ENABLE | PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles),
> - lpc32xx->base + (pwm->hwpwm << 2));
> + val = readl(lpc32xx->base + (pwm->hwpwm << 2));
> + val &= ~0xFFFF;
> + val |= PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles);
> + writel(val, lpc32xx->base + (pwm->hwpwm << 2));
>
> return 0;
> }



\
 
 \ /
  Last update: 2013-04-23 11:01    [W:0.063 / U:2.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site