lkml.org 
[lkml]   [2013]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 099/124] sky2: Threshold for Pause Packet is set wrong
    Date
    3.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Mirko Lindner <mlindner@marvell.com>

    [ Upstream commit 74f9f42c1c1650e74fb464f76644c9041f996851 ]

    The sky2 driver sets the Rx Upper Threshold for Pause Packet generation to a
    wrong value which leads to only 2kB of RAM remaining space. This can lead to
    Rx overflow errors even with activated flow-control.

    Fix: We should increase the value to 8192/8

    Signed-off-by: Mirko Lindner <mlindner@marvell.com>
    Acked-by: Stephen Hemminger <stephen@networkplumber.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/marvell/sky2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/marvell/sky2.c
    +++ b/drivers/net/ethernet/marvell/sky2.c
    @@ -1067,7 +1067,7 @@ static void sky2_ramset(struct sky2_hw *
    sky2_write32(hw, RB_ADDR(q, RB_RX_UTHP), tp);
    sky2_write32(hw, RB_ADDR(q, RB_RX_LTHP), space/2);

    - tp = space - 2048/8;
    + tp = space - 8192/8;
    sky2_write32(hw, RB_ADDR(q, RB_RX_UTPP), tp);
    sky2_write32(hw, RB_ADDR(q, RB_RX_LTPP), space/4);
    } else {



    \
     
     \ /
      Last update: 2013-04-03 00:41    [W:4.079 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site