Messages in this thread | | | Date | Fri, 19 Apr 2013 12:55:16 -0400 | From | Jörn Engel <> | Subject | Re: [PATCH] mtd: Convert logging messages |
| |
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote: > } > list_add(&dev->list, &blkmtd_device_list); > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index, > - dev->mtd.name + strlen("block2mtd: "), > - dev->mtd.erasesize >> 10, dev->mtd.erasesize); > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n", > + dev->mtd.index, > + dev->mtd.name + strlen("block2mtd: "), > + dev->mtd.erasesize >> 10, dev->mtd.erasesize);
I personally dislike the indent-to-braces style because it causes unnecessary churn in patches like this. The reindenting improves nothing at all. On the contrary, when going through revision history at some point in the future I have to waste brain time to verify whether any function change has slipped in or not. It doesn't just waste my time right now, it will continue to waste time in the future. It will waste time when people care about revision history because they encounter a bug, want a fix quick and are pressed for time.
If you care about my ack, please remove random churn. This is not a competition about who gets the most lines in git blame.
Jörn
-- Public Domain - Free as in Beer General Public - Free as in Speech BSD License - Free as in Enterprise Shared Source - Free as in "Work will make you..." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |