Messages in this thread | | | Subject | Re: [PATCH 1/4] mfd: Kontron PLD mfd driver | From | Joe Perches <> | Date | Wed, 17 Apr 2013 21:40:53 -0700 |
| |
On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > > Please > Wondering .... why does checkpatch not report those ?
because checkpatch doesn't care about spacing around arithmetic as long as it's consistent.
Documentation/CodingStyle doesn't say anything about it either.
Look around checkpatch line 2654
} elsif ($op eq '<<' or $op eq '>>' or $op eq '&' or $op eq '^' or $op eq '|' or $op eq '+' or $op eq '-' or $op eq '*' or $op eq '/' or $op eq '%') { if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { ERROR("SPACING", "need consistent spacing around '$op' $at\n" . $hereptr); }
| |