Messages in this thread | | | Date | Wed, 10 Apr 2013 22:06:10 +0200 | Subject | Re: [PATCH 3/4] gpio: Kontron PLD gpio driver | From | Linus Walleij <> |
| |
On Tue, Apr 9, 2013 at 6:41 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote: >> On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser >> <kevin.strasser@linux.intel.com> wrote: >> >> > From: Michael Brunner <michael.brunner@kontron.com> >> > >> > Add gpio support for the on-board PLD found on some Kontron embedded >> > modules. >> > >> > Signed-off-by: Michael Brunner <michael.brunner@kontron.com> >> > Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com> >> >> This looks very generic, setting and clearing bits in bytesized >> registers. >> >> Can you please attempt to use generic GPIO for this? >> > Linus, > > I looked into it, but for my part I seem to be missing how the generic GPIO code > permits locking access to the hardware (PLD) and setting the PLD's page register. > In other words, I don't immediately see how to call kempld_get_mutex_set_index() > from the generic GPIO code. The other drivers using generic GPIO code don't > seem to have that requirement.
Ah yes, I was totally wrong here.
I thought it was MMIO while it is indeed through an MFD proxy.
I'll have a second look then...
Yours, Linus Walleij
| |