lkml.org 
[lkml]   [2013]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pwm: spear: Fix enable pwm output
From
On 30 March 2013 09:16, Axel Lin <axel.lin@ingics.com> wrote:
> The logic to check return value of clk_enable() is reversed, thus
> when clek_enable() success PWMCR_PWM_ENABLE bit is never set. Fix it.

s/clek/clk

And write it as:

The logic to check return value of clk_enable() is reversed, thus
when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it.

>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 69a2d9e..cccb430 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -143,7 +143,7 @@ static int spear_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> u32 val;
>
> rc = clk_enable(pc->clk);
> - if (!rc)
> + if (rc)
> return rc;

This is okay but there is one more mistake like this in this driver.
Fix that too.


\
 
 \ /
  Last update: 2013-03-30 05:41    [W:0.043 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site