Messages in this thread | | | Date | Thu, 28 Mar 2013 11:29:00 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] gpio: palmas: add dt support |
| |
On Wednesday 27 March 2013 06:30 PM, Linus Walleij wrote: > On Thu, Mar 21, 2013 at 3:30 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote: > >> +#ifdef CONFIG_OF >> +static struct of_device_id of_palmas_gpio_match[] = { >> + { .compatible = "ti,palmas-gpio"}, >> + { }, >> +}; >> +MODULE_DEVICE_TABLE(of, of_palmas_gpio_match); >> +#endif > But please drop the #ifdef here unless it causes compile errors > (I don't think it will.) >
I am using this table as
driver.of_match_table = of_match_ptr(of_palmas_gpio_match), of_match_ptr is macro which is NULL in case of CONFIG_OF not defined. So if I remove ifdefs then it may create build warning as unused variable.
Therefore, I think it is require here.
| |