lkml.org 
[lkml]   [2013]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] clk: abstract locking out into helper functions
    On Wed, 27 Mar 2013, Mike Turquette wrote:

    > Create locking helpers for the global mutex and global spinlock. The
    > definitions of these helpers will be expanded upon in the next patch
    > which introduces reentrancy into the locking scheme.

    This looks way better. Nitpick below.

    > +static void clk_enable_lock(unsigned long *flags)
    > +{
    > + spin_lock_irqsave(&enable_lock, *flags);
    > +}

    > +static void clk_enable_unlock(unsigned long *flags)

    Please just hand in the flags, no need for indirection.

    > +{
    > + spin_unlock_irqrestore(&enable_lock, *flags);
    > +}
    > +

    Reviewed-by: Thomas Gleixner <tglx@linutronix.de>



    \
     
     \ /
      Last update: 2013-03-28 11:01    [W:4.056 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site