Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH v2] wait while adding MMC host to ensure root mounts | Date | Wed, 27 Mar 2013 07:57:34 -0400 |
| |
Hi,
On Wed, Mar 27 2013, Ulf Hansson wrote: > I noticed you merged this. I thought the idea was to use the rootwait > or rootdelay?
That's necessary before the patch, but it would be better if we didn't have to pass rootwait, all else being equal.
> Moreover, this patch will have bad impact on booting the kernel, since > every host device that has scheduled a detect work from it's probe > function will also wait for it to finish. Even if it is the boot > device of not. If this is needed, I would prefer that a host cap is > used.
I see, you're worried about a performance regression where every boot takes longer than it used to while MMC quiesces. That's fair. Do you think you could tell me how much delay this adds to a boot for you, so that we can consider whether the usability improvement is worth it?
If the delay's significant, I agree with you and will revert this patch.
Thanks,
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child
| |