lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 18/23] tty: Remove stale comment re: tty_ldisc_flush_works()
    Date
    Waiting for a pending hangup to complete is not a necessary
    post-operation of using tty_ldisc_halt() and not sufficient to
    guarantee a hangup is not in-progress. As far as the ldisc layer
    is concerned, waiting for a pending hangup is necessary only
    prior to changing the ldisc while handling the TIOCSETD ioctl (and
    only because the tty lock must be released as a precondition
    of halting the ldisc).

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/tty_ldisc.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
    index 9599b05..f3cbfb3 100644
    --- a/drivers/tty/tty_ldisc.c
    +++ b/drivers/tty/tty_ldisc.c
    @@ -538,10 +538,6 @@ static int tty_ldisc_wait_idle(struct tty_struct *tty, long timeout)
    *
    * Callers other than tty_ldisc_release() must hold ->ldisc_mutex and
    * cannot be holding tty_lock() (aka legacy_mutex).
    - *
    - * You need to do a 'flush_scheduled_work()' (outside the ldisc_mutex)
    - * in order to make sure any currently executing ldisc work is also
    - * flushed.
    */

    static int tty_ldisc_halt(struct tty_struct *tty, struct tty_struct *o_tty,
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-02-05 22:23    [W:2.504 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site