Messages in this thread | | | Date | Thu, 28 Feb 2013 11:20:10 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/2] watchdog: add Palmas Watchdog support |
| |
On Thursday 28 February 2013 12:06 AM, Ian Lartey wrote: > From: Graeme Gregory <gg@slimlogic.co.uk> > > Add support for the Palmas watchdog timer which has a timeout configurable > from 1s to 128s. > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk> > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk> > --- > drivers/watchdog/palmas_wdt.c | 291 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 291 insertions(+), 0 deletions(-) > create mode 100644 drivers/watchdog/palmas_wdt.c
patch 1 and 2 can be merge as single patch.
generic comment, we have proper watchdog framework where we can have some api for watchdog_ops and register as watchdog_register_device(). Then core parts take care of the all fileops/sysfs interface. This need not to be develop locally.
You can refer wm831x_wdt.c, wm8350_wdt.c driver for more reference where it is really used watchdog framework.
I think you can use the watchdog framework for this.
| |